Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

12 LTS #323

Open
wants to merge 52 commits into
base: master
Choose a base branch
from
Open

12 LTS #323

wants to merge 52 commits into from

Conversation

jonaseberle
Copy link
Member

@jonaseberle jonaseberle commented Nov 3, 2023

Continuation of rebased #311.

Necessary changes:

Asset paths in TypoScript

_asset paths in TypoScript can be added with

  inject.insertData = 1
  inject = <script src="/{path : EXT:....}">

(mind the leading /!)
but this has shortcomings (see https://forge.typo3.org/issues/99203#change-507069). For v13 we'll get the {asset : ...} getText (https://review.typo3.org/c/Packages/TYPO3.CMS/+/77018).

f:translate in non-Extbase contexts

Due to a probable requirement for extensionName in each {f:translate} instance (forge issue: https://forge.typo3.org/issues/102315) it is very probable that custom templates will break. That would warrant a major (breaking) release for cookieman.

Translations in TypoScript (solved in TYPO3 Core v12.4.9+)

Adding translations with plugin.*._LOCAL_LANG in page layout context did also not work anymore in TYPO3v12 (https://forge.typo3.org/issues/100759) - (This is solved for v12.4.9+ by https://review.typo3.org/c/Packages/TYPO3.CMS/+/82023)

We might have to recommend this instead:

# @see https://docs.typo3.org/m/typo3/reference-coreapi/12.4/en-us/ApiOverview/Localization/ManagingTranslations.html#custom-translations
$GLOBALS['TYPO3_CONF_VARS']['SYS']['locallangXMLOverride']['EXT:cookieman/Resources/Private/Language/locallang.xlf'][]
        = 'EXT:configure_cookieman/Resources/Private/Language/locallang_cookieman.xlf';
$GLOBALS['TYPO3_CONF_VARS']['SYS']['locallangXMLOverride']['de']['EXT:cookieman/Resources/Private/Language/locallang.xlf'][]
        = 'EXT:configure_cookieman/Resources/Private/Language/de.locallang_cookieman.xlf';

How to use this:

composer req dmind/cookieman:dev-dev/12lts (or, pin a commit when using it in production: for example dmind/cookieman:dev-dev/12lts#cc9364f4ba76de706f4af2a3e1be7372aaabba09)
– please test and give feedback

Fixes: #304
Fixes: #271

@jonaseberle
Copy link
Member Author

The _LOCAL_LANG TypoScript issue should be solved in TYPO3 v12.4.9+ by https://review.typo3.org/c/Packages/TYPO3.CMS/+/82023.

@jonaseberle jonaseberle force-pushed the dev/12lts branch 2 times, most recently from 105f7bf to fbfa0ee Compare February 6, 2024 19:07
@derhansen
Copy link

👍 Works like a charm. Would be great to get this merged.

@cundd
Copy link
Contributor

cundd commented Dec 3, 2024

In my tests this PR also works for TYPO3 v13 (after patching composer.json)

@cundd
Copy link
Contributor

cundd commented Dec 4, 2024

Would it make sense to create a tag for a beta-release? So one could install the latest version with composer, but the documentation would not need to be complete yet?

(cherry picked from commit d9a36c8)
Relates: #339
Relates: #314
(cherry picked from commit 44ebe81)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TYPO3 12 compatibility typo3/cms-composer-installers:^4 compatibility will need some work
3 participants