-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
12 LTS #323
base: master
Are you sure you want to change the base?
12 LTS #323
Conversation
The _LOCAL_LANG TypoScript issue should be solved in TYPO3 v12.4.9+ by https://review.typo3.org/c/Packages/TYPO3.CMS/+/82023. |
105f7bf
to
fbfa0ee
Compare
fbfa0ee
to
923bf1f
Compare
👍 Works like a charm. Would be great to get this merged. |
In my tests this PR also works for TYPO3 v13 (after patching composer.json) |
8e4ec46
to
d5a1ece
Compare
Would it make sense to create a tag for a beta-release? So one could install the latest version with composer, but the documentation would not need to be complete yet? |
(cherry picked from commit d9a36c8)
Continuation of rebased #311.
Necessary changes:
inject ()
asset
in v13.2+ https://docs.typo3.org/m/typo3/reference-typoscript/main/en-us/Functions/Data.html#asset)Asset paths in TypoScript
_asset paths in TypoScript can be added with
(mind the leading
/
!)but this has shortcomings (see https://forge.typo3.org/issues/99203#change-507069). For v13 we'll get the
{asset : ...}
getText (https://review.typo3.org/c/Packages/TYPO3.CMS/+/77018).f:translate in non-Extbase contexts
Due to a probable requirement for
extensionName
in each{f:translate}
instance (forge issue: https://forge.typo3.org/issues/102315) it is very probable that custom templates will break. That would warrant a major (breaking) release for cookieman.Translations in TypoScript (solved in TYPO3 Core v12.4.9+)
Adding translations with
plugin.*._LOCAL_LANG
in page layout context did also not work anymore in TYPO3v12 (https://forge.typo3.org/issues/100759) - (This is solved for v12.4.9+ by https://review.typo3.org/c/Packages/TYPO3.CMS/+/82023)We might have to recommend this instead:
How to use this:
composer req dmind/cookieman:dev-dev/12lts
(or, pin a commit when using it in production: for exampledmind/cookieman:dev-dev/12lts#cc9364f4ba76de706f4af2a3e1be7372aaabba09
)– please test and give feedback
Fixes: #304
Fixes: #271