Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended extension (own) cookie configuration. #337

Open
wants to merge 4 commits into
base: dev/12lts
Choose a base branch
from

Conversation

ax-ha
Copy link

@ax-ha ax-ha commented Jul 19, 2024

Domain, sameSite and duration are now configurable within typoscript.
I started as suggested with the domain property but then I decided that the other fields might be useful, too.

Still open:

  • add/extend tests

  • add more documentation

  • perhaps extending the validation of the typoscript settings might be a good idea.

  • do the same for the master branch to support typo3 11 as well

With these changes I had been able to run a TYPO3 12 instance with two sites on the same main domain.
Like site1.domain.com and site2.domain.com. Now the user is not forced to re-submit his cookie settings when he switches between these sites (subdomains).
If the domain property is empty in the typoscript settings, the cookie will be set as before.

Example:
plugin.tx_cookieman {
    settings {
        cookie {
            # cookie expire time in days (default: 365)
            cookieLifetimeDays = 

            # domain without protocol like www.example.com, .example.com (default: Typo3 site name)
            domain = .domain.com

            # sameSite Options: Lax, Strict or None (default: lax)
            sameSite = Lax             
        }
    }
}

ax-ha added 2 commits July 19, 2024 15:57
Domain, sameSite and duration are now configurable within typoscriot.
@jonaseberle
Copy link
Member

Sorry, I have not seen your PR earlier. I'll come back to it shortly.

@jonaseberle jonaseberle added the enhancement New feature or request label Sep 6, 2024
@jonaseberle
Copy link
Member

Thank you!
What we need for sure before merging is documentation for the new Typoscript settings.

@jonaseberle
Copy link
Member

Relates: #299

@ax-ha
Copy link
Author

ax-ha commented Sep 10, 2024

Alright. I will add some documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants