Skip to content

Commit

Permalink
Fix slider step
Browse files Browse the repository at this point in the history
Use the value of the `step` attribute if no keyboard steps are specified.
  • Loading branch information
dmitrylyzo committed Aug 23, 2023
1 parent b2f3720 commit 7d27596
Showing 1 changed file with 25 additions and 4 deletions.
29 changes: 25 additions & 4 deletions src/elements/emby-slider/emby-slider.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,27 @@ import '../emby-input/emby-input';
}
}

/**
* Returns normalized slider step.
*
* @param {HTMLInputElement} range slider itself
* @param {number|undefined} step step
* @returns {number} normalized slider step.
*/
function normalizeSliderStep(range, step) {
if (step > 0) {
return step;
}

step = parseFloat(range.step);

if (step > 0) {
return step;
}

return 1;
}

/**
* Returns slider fraction corresponding to client position.
*
Expand All @@ -35,7 +56,7 @@ import '../emby-input/emby-input';
// Snap to step
const valueRange = range.max - range.min;
if (range.step !== 'any' && valueRange !== 0) {
const step = (range.step || 1) / valueRange;
const step = normalizeSliderStep(range) / valueRange;
fraction = Math.round(fraction / step) * step;
}

Expand All @@ -54,7 +75,7 @@ import '../emby-input/emby-input';

// Snap to step
if (range.step !== 'any') {
const step = range.step || 1;
const step = normalizeSliderStep(range);
value = Math.round(value / step) * step;
}

Expand Down Expand Up @@ -377,13 +398,13 @@ import '../emby-input/emby-input';
switch (keyboardnavigation.getKeyName(e)) {
case 'ArrowLeft':
case 'Left':
stepKeyboard(this, -this.keyboardStepDown || -1);
stepKeyboard(this, -normalizeSliderStep(this, this.keyboardStepDown));
e.preventDefault();
e.stopPropagation();
break;
case 'ArrowRight':
case 'Right':
stepKeyboard(this, this.keyboardStepUp || 1);
stepKeyboard(this, normalizeSliderStep(this, this.keyboardStepUp));
e.preventDefault();
e.stopPropagation();
break;
Expand Down

0 comments on commit 7d27596

Please sign in to comment.