Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

random: rename srand! to srand #282

Merged
merged 2 commits into from
Oct 5, 2017
Merged

random: rename srand! to srand #282

merged 2 commits into from
Oct 5, 2017

Conversation

iblislin
Copy link
Member

@iblislin iblislin commented Sep 13, 2017 •
edited
Loading

make it same as Base

--

TODO

  • update NEWS.md
  • update deprecated.jl

vchuravy
vchuravy approved these changes Sep 17, 2017
View reviewed changes
Copy link
Collaborator

@vchuravy vchuravy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved once it is properly deprecated

@vchuravy
Copy link
Collaborator

bump rebase and finish todos.

@iblislin
random: rename srand! to srand
ff0556b 
make it same as Base
@iblislin
Copy link
Member Author

updated

@iblislin
random: update NEWS and deprecated.jl
5b3c507 
- update NEWS for deepcopy on NDArray as well (dmlc#273)
@codecov-io
Copy link

codecov-io commented Sep 25, 2017 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@6d1ba53). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #282   +/-   ##
=========================================
  Coverage          ?   69.56%           
=========================================
  Files             ?       25           
  Lines             ?     1909           
  Branches          ?        0           
=========================================
  Hits              ?     1328           
  Misses            ?      581           
  Partials          ?        0
Impacted Files Coverage Δ
src/random.jl 100% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d1ba53...5b3c507. Read the comment docs.

@iblislin
Copy link
Member Author

iblislin commented Oct 4, 2017

good to go?

@vchuravy vchuravy merged commit 0a53778 into dmlc:master Oct 5, 2017
@iblislin iblislin deleted the srand branch October 5, 2017 15:04
@iblislin iblislin added this to the v0.3.0 milestone Nov 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vchuravy vchuravy vchuravy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@iblislin @vchuravy @codecov-io