-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] [NN] Refactor NN package #406
Conversation
@jermainewang I assume only the examples will be affected and the tutorials are left unchanged? |
Yes. |
@jermainewang I'm done and you may take a look. There are some additional changes that I did not realize until now (the ones in |
Yes |
Did some minor fix on MXNet side. Thanks Murphy! |
Description
This PR refactor the out-of-date NN package. Some guidelines:
dgl.nn.pytorch
. This is because the interface might be quite different for different backends.Checklist
Please feel free to remove inapplicable items for your PR.
or have been fixed to be compatible with this change
Changes
dgl.nn.pytorch.conv.GraphConv
dgl.nn.pytorch.softmax.EdgeSoftmax
dgl.nn.mxnet.conv.GraphConv
Additional Note
nn
modules into the examples seem to have slowed down the speed of execution as there are some redundant operations of setting and popping data.