Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GRAPHBOLT] Activation of several graphbolt tests for CPU #7586

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

drivanov
Copy link
Contributor

@drivanov drivanov commented Jul 26, 2024

Description

The few existing graphbolt have been modified to run on the CPU as well.

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 26, 2024

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 26, 2024

Commit ID: 6267f4c

Build ID: 1

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 26, 2024

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 26, 2024

Commit ID: 86025b3cb1480ef598538b786531861f42ad2f20

Build ID: 2

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@drivanov drivanov changed the title [GRAPHBOLT] Activation of test_exclude_seed_edges for CPU [GRAPHBOLT] Activation of several graphbolt tests for CPU Jul 26, 2024
@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 31, 2024

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 31, 2024

Commit ID: 578b497

Build ID: 3

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@frozenbugs
Copy link
Collaborator

@dgl-bot

@frozenbugs frozenbugs self-requested a review August 8, 2024 02:21
@dgl-bot
Copy link
Collaborator

dgl-bot commented Aug 8, 2024

Commit ID: 792d0ddf588f2fe1925f679dc6b82bb3985eeb67

Build ID: 4

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@@ -970,7 +966,7 @@ def test_SubgraphSampler_unique_csc_format_Homo_Node_gpu(labor):
deduplicate=True,
)

if torch.cuda.get_device_capability()[0] < 7:
if F.ctx() != F.cpu() and torch.cuda.get_device_capability()[0] < 7:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to keep the check on the top of the test cases. CPU is actually not running even after your fix.

@dgl-bot
Copy link
Collaborator

dgl-bot commented Aug 8, 2024

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Aug 8, 2024

Commit ID: 672889a

Build ID: 5

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants