add qid as ranklib format #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiangbai
approved these changes
Dec 14, 2017
tqchen
requested changes
Jan 7, 2018
include/dmlc/data.h
Outdated
| @@ -73,6 +73,8 @@ class Row { | |||
| const real_t *label; | |||
| /*! \brief weight of the instance */ | |||
| const real_t *weight; | |||
| /*! \brief session-id of the instance */ | |||
| const size_t *qid; | |||
There was a problem hiding this comment.
use int32_t, as size_t is not portable across platforms
There was a problem hiding this comment.
if there is worry about possible integer overflow, use uint64_t instead
There was a problem hiding this comment.
thanks, I have changed it to uint64_t.
tqchen
approved these changes
Jan 9, 2018
hcho3
added a commit
to hcho3/dmlc-core
that referenced
this pull request
Jun 30, 2018
This is a follow-up of dmlc#317. Due to an incorrect pointer arithmetic, the query-id (qid) information in each row was also being inserted into the `offset` array. To re-produce the problem, run the LibSVMParser.test_qid test without the bug fix.
hcho3
added a commit
that referenced
this pull request
Jun 30, 2018
This is a follow-up of #317. Due to an incorrect pointer arithmetic, the query-id (qid) information in each row was also being inserted into the `offset` array. To re-produce the problem, run the LibSVMParser.test_qid test without the bug fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add qid data format like ranklib,for ranking task.
dmlc/xgboost#2748
example:
0 qid:1 1:1.0 2:1.0 5:7.0 7:0.0
1 qid:1 1:0.0 2:1.0 5:2.0 7:0.0 8:0.5
1 qid:2 1:0.0 2:1.0 5:2.0 7:0.0 8:1.0
...