Add OpenMP as CMake target #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hcho3
force-pushed
the
modernize_openmp
branch
from
af7f183
to
26819d7
Compare
hcho3
force-pushed
the
modernize_openmp
branch
from
f1c1103
to
12aec58
Compare
|
Sorry for the noise. I'm now done ironing out all loose ends. This PR is now ready for review. |
trivialfis
reviewed
Dec 23, 2019
|
@trivialfis Do you mean that we should remove unittest_gtest for OSX? |
|
@hcho3 No. I see package |
|
@trivialfis I put back gcc. Now dmlc-core is tested against both gcc and Apple Clang. |
hcho3
force-pushed
the
modernize_openmp
branch
from
947d270
to
25bcdec
Compare
trivialfis
approved these changes
Dec 26, 2019
|
sorry I missed this LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify logic for importing OpenMP into the CMake build by treating OpenMP as a target. This way, we no longer have to set compiler flags to enable OpenMP. See https://cliutils.gitlab.io/modern-cmake/chapters/packages/OpenMP.html for more information.
@dmlc/dmlc-core-committer @trivialfis Please help review. This will be especially useful for Mac OSX users. The old way requires them to use Homebrew GCC, which is a heavy dependency (*). The new way allows them to use Apple Clang (default system compiler) instead.
(*) See discussion at Homebrew/homebrew-core#43246, where Homebrew maintainers asked to remove GCC dependency from XGBoost.