Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

Fix ETA for eval_validation #1585

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix ETA for eval_validation #1585

wants to merge 1 commit into from

Conversation

bartekkuncer
Copy link

@bartekkuncer bartekkuncer commented Apr 7, 2022 •
edited
Loading

Description

Fixes ETA for eval_validation when max_seq_length has been changed.

Fixes: #1586

w/o the fix:
image

with:
image

cc @dmlc/gluon-nlp-team

@bartekkuncer bartekkuncer requested a review from a team as a code owner April 7, 2022 16:34
szha
szha approved these changes Apr 7, 2022
View reviewed changes
Copy link
Member

@szha szha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bgawrych bgawrych bgawrych approved these changes

@anko-intel anko-intel anko-intel approved these changes

@szha szha szha approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong ETA for max_seq_length != 512
4 participants
@bartekkuncer @szha @anko-intel @bgawrych