This repository has been archived by the owner on Oct 15, 2019. It is now read-only.
none checking on owl + removal of compiled pyx files #49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into a number of odd errors when accidentally passing None into owl functions. Turns out cython just tries to accept them and they turn into invalid memory causing segfaults. (https://github.com/cython/cython/wiki/FAQ#why-does-a-function-with-cdef-d-parameters-accept-none) This pull request tries to fix that. In addition I removed the generated cpp file for the pyx file.
The new errors look something like:
The old error looks like:
To my knowledge there are no tests for this pyx file. In addition I cannot run the cuda code on my current machine but to my knowledge this shouldn't break anything.