Skip to content
This repository has been archived by the owner on Aug 11, 2020. It is now read-only.

check and close fp16 with arm #337

Closed
wants to merge 2 commits into from
Closed

Conversation

yajiedesign
Copy link
Contributor

No description provided.

@rahul003
Copy link
Contributor

rahul003 commented May 2, 2018

This should already be handled by Make and CMake. F16C will not be turned on for ARM builds. Did you run into some issue?

@yajiedesign
Copy link
Contributor Author

yes.some issue.https://discuss.gluon.ai/t/topic/6100/7

@szha
Copy link
Member

szha commented Jun 22, 2018

@tqchen

@rahul003
Copy link
Contributor

rahul003 commented Jun 22, 2018

Hello Sheng, this mostly wouldn't fix the issue faced by that user. If you look at the error log in that thread it has
-DMSHADOW_USE_F16C=0 which indicates that the makefile is already taking care of this, checking compiler and setting this flag is redundant.

@szha
Copy link
Member

szha commented Jun 22, 2018

Thanks. Then the broken amalgamation is due to something else.

@rahul003
Copy link
Contributor

rahul003 commented Jun 22, 2018

Amalgamation isn't broken per se. It's tested in MXNet CI for both MIN=1 and MIN=0 flags. I also see a new step for android on the CI.
Here's an example recent successful run on master
http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/incubator-mxnet/detail/master/1037/pipeline

There's something else about this user's environment.

@szha
Copy link
Member

szha commented Aug 4, 2019

This code base has been donated to the Apache MXNet project per #373, and repo is deprecated. Future development should continue in Apache MXNet.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@szha szha closed this Jul 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants