Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tracker_ in ps-lite/include/ps/internal/customer.h never erase element. is that ok? #96

Open
cuteapi opened this issue Apr 13, 2017 · 1 comment
Open

tracker_ in ps-lite/include/ps/internal/customer.h never erase element. is that ok? #96

cuteapi opened this issue Apr 13, 2017 · 1 comment

Comments

@cuteapi
Copy link

cuteapi commented Apr 13, 2017 •
edited
Loading

when worker do pull or push operation . a pair will be push_back to tracker_ in Customer. but never be erased. when program run a long time. this vector will be very large. is that ok?
@crafet
Copy link

crafet commented Mar 8, 2018

seems you are right
how about erasing the ts after Customer::WaitRequest return?

eric-haibin-lin added a commit to eric-haibin-lin/ps-lite that referenced this issue Oct 15, 2021
@eric-haibin-lin
rdmavan: reduce scheduler memory consumption (dmlc#96)
7f69aa2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@crafet @cuteapi