Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use shared ptr for net link. #144

Closed
wants to merge 2 commits into from
Closed

Use shared ptr for net link. #144

wants to merge 2 commits into from

Conversation

trivialfis
Copy link
Member

@trivialfis trivialfis commented Aug 13, 2020 •
edited
Loading

I ran into an issue with expired pointer in tree_links. So far the issue is not reproducible on JenkinsCI and I can't find the root cause. So I changed everything to shared ptr ...

@trivialfis
Copy link
Member Author

@RAMitchell

RAMitchell
RAMitchell approved these changes Aug 14, 2020
View reviewed changes
Copy link
Member

@RAMitchell RAMitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay in my non-expert opinion.

@hcho3
Copy link
Contributor

hcho3 commented Nov 5, 2020

Recent developments of Rabit have been moved into the XGBoost repository. See discussion in dmlc/xgboost#5995.

@hcho3 hcho3 closed this Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RAMitchell RAMitchell RAMitchell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trivialfis @hcho3 @RAMitchell