Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Upgrade github workflows to use latest Conda setup action #563

Merged
merged 6 commits into from
May 23, 2024

Conversation

hcho3
Copy link
Collaborator

@hcho3 hcho3 commented May 22, 2024

This should unblock the CI in #562

Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.67%. Comparing base (35b90e8) to head (c892161).
Report is 12 commits behind head on mainline.

Additional details and impacted files
@@             Coverage Diff              @@
##           mainline     #563      +/-   ##
============================================
+ Coverage     84.57%   84.67%   +0.09%     
============================================
  Files            71       71              
  Lines          6180     6330     +150     
  Branches        518      521       +3     
============================================
+ Hits           5227     5360     +133     
- Misses          953      970      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Philip! 🙏

Had a suggestion below

.github/workflows/coverage-tests.yml Outdated Show resolved Hide resolved
@jakirkham
Copy link

Thanks Hyunsu! 🙏

Looks like we are getting more green checkmarks (though have looked deeper)

Appears Windows may need the same treatment?

@hcho3 hcho3 merged commit 890f605 into dmlc:mainline May 23, 2024
19 checks passed
@hcho3 hcho3 deleted the fix_ci branch May 23, 2024 04:43
@jakirkham
Copy link

Thanks Hyunsu! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants