Add Github Action for R. (#5911)

* Fix lintr errors.

.github/workflows/main.yml

@@ -0,0 +1,52 @@
+# This is a basic workflow to help you get started with Actions
+
+name: XGoost-CI
+
+# Controls when the action will run. Triggers the workflow on push or pull request
+# events but only for the master branch
+on: [push, pull_request]
+
+# A workflow run is made up of one or more jobs that can run sequentially or in parallel
+jobs:
+  test-with-R:
+    runs-on: ${{ matrix.config.os }}
+
+    name: Test R on OS ${{ matrix.config.os }}, R (${{ matrix.config.r }})
+
+    strategy:
+      fail-fast: false
+      matrix:
+        config:
+          - {os: windows-latest, r: 'release'}
+    env:
+      R_REMOTES_NO_ERRORS_FROM_WARNINGS: true
+      RSPM: ${{ matrix.config.rspm }}
+
+    steps:
+    - uses: actions/checkout@v2
+      with:
+        submodules: 'true'
+
+    - uses: r-lib/actions/setup-r@master
+      with:
+        r-version: ${{ matrix.config.r }}
+
+    - name: Install dependencies
+      shell: Rscript {0}
+      run: |
+        install.packages(c('XML','igraph'))
+        install.packages(c('data.table','magrittr','stringi','ggplot2','DiagrammeR','Ckmeans.1d.dp','vcd','testthat','lintr','knitr','rmarkdown'))
+
+    - name: Config R
+      run: |
+        mkdir build && cd build
+        cmake .. -DCMAKE_CONFIGURATION_TYPES="Release" -DR_LIB=ON
+
+    - name: Build R
+      run: |
+        cmake --build build --target install --config Release
+
+    - name: Test R
+      run: |
+        cd R-package
+        R.exe -q -e "library(testthat); setwd('tests'); source('testthat.R')"

R-package/R/callbacks.R

@@ -62,11 +62,11 @@ cb.print.evaluation <- function(period = 1, showsd = TRUE) {
   callback <- function(env = parent.frame()) {
     if (length(env$bst_evaluation) == 0 ||
         period == 0 ||
-        NVL(env$rank, 0) != 0 )
+        NVL(env$rank, 0) != 0)
       return()
 
     i <- env$iteration
-    if ((i-1) %% period == 0 ||
+    if ((i - 1) %% period == 0 ||
         i == env$begin_iteration ||
         i == env$end_iteration) {
       stdev <- if (showsd) env$bst_evaluation_err else NULL
@@ -115,20 +115,20 @@ cb.evaluation.log <- function() {
       stop("bst_evaluation must have non-empty names")
 
     mnames <<- gsub('-', '_', names(env$bst_evaluation))
-    if(!is.null(env$bst_evaluation_err))
+    if (!is.null(env$bst_evaluation_err))
       mnames <<- c(paste0(mnames, '_mean'), paste0(mnames, '_std'))
   }
 
   finalizer <- function(env) {
     env$evaluation_log <- as.data.table(t(simplify2array(env$evaluation_log)))
     setnames(env$evaluation_log, c('iter', mnames))
 
-    if(!is.null(env$bst_evaluation_err)) {
+    if (!is.null(env$bst_evaluation_err)) {
       # rearrange col order from _mean,_mean,...,_std,_std,...
       # to be _mean,_std,_mean,_std,...
       len <- length(mnames)
-      means <- mnames[seq_len(len/2)]
-      stds <- mnames[(len/2 + 1):len]
+      means <- mnames[seq_len(len / 2)]
+      stds <- mnames[(len / 2 + 1):len]
       cnames <- numeric(len)
       cnames[c(TRUE, FALSE)] <- means
       cnames[c(FALSE, TRUE)] <- stds
@@ -144,7 +144,7 @@ cb.evaluation.log <- function() {
       return(finalizer(env))
 
     ev <- env$bst_evaluation
-    if(!is.null(env$bst_evaluation_err))
+    if (!is.null(env$bst_evaluation_err))
       ev <- c(ev, env$bst_evaluation_err)
     env$evaluation_log <- c(env$evaluation_log,
                             list(c(iter = env$iteration, ev)))
@@ -351,13 +351,13 @@ cb.early.stop <- function(stopping_rounds, maximize = FALSE,
 
   finalizer <- function(env) {
     if (!is.null(env$bst)) {
-      attr_best_score = as.numeric(xgb.attr(env$bst$handle, 'best_score'))
+      attr_best_score <- as.numeric(xgb.attr(env$bst$handle, 'best_score'))
       if (best_score != attr_best_score)
         stop("Inconsistent 'best_score' values between the closure state: ", best_score,
              " and the xgb.attr: ", attr_best_score)
-      env$bst$best_iteration = best_iteration
-      env$bst$best_ntreelimit = best_ntreelimit
-      env$bst$best_score = best_score
+      env$bst$best_iteration <- best_iteration
+      env$bst$best_ntreelimit <- best_ntreelimit
+      env$bst$best_score <- best_score
     } else {
       env$basket$best_iteration <- best_iteration
       env$basket$best_ntreelimit <- best_ntreelimit
@@ -372,9 +372,9 @@ cb.early.stop <- function(stopping_rounds, maximize = FALSE,
       return(finalizer(env))
 
     i <- env$iteration
-    score = env$bst_evaluation[metric_idx]
+    score <- env$bst_evaluation[metric_idx]
 
-    if (( maximize && score > best_score) ||
+    if ((maximize && score > best_score) ||
         (!maximize && score < best_score)) {
 
       best_msg <<- format.eval.string(i, env$bst_evaluation, env$bst_evaluation_err)
@@ -500,7 +500,7 @@ cb.cv.predict <- function(save_models = FALSE) {
     for (fd in env$bst_folds) {
       pr <- predict(fd$bst, fd$watchlist[[2]], ntreelimit = ntreelimit, reshape = TRUE)
       if (is.matrix(pred)) {
-        pred[fd$index,] <- pr
+        pred[fd$index, ] <- pr
       } else {
         pred[fd$index] <- pr
       }
@@ -613,9 +613,7 @@ cb.gblinear.history <- function(sparse=FALSE) {
 
   init <- function(env) {
     if (!is.null(env$bst)) { # xgb.train:
-      coef_path <- list()
     } else if (!is.null(env$bst_folds)) { # xgb.cv:
-      coef_path <- rep(list(), length(env$bst_folds))
     } else stop("Parent frame has neither 'bst' nor 'bst_folds'")
   }
 
@@ -705,11 +703,11 @@ xgb.gblinear.history <- function(model, class_index = NULL) {
   if (!is_cv) {
     # extract num_class & num_feat from the internal model
     dmp <- xgb.dump(model)
-    if(length(dmp) < 2 || dmp[2] != "bias:")
+    if (length(dmp) < 2 || dmp[2] != "bias:")
       stop("It does not appear to be a gblinear model")
-    dmp <- dmp[-c(1,2)]
+    dmp <- dmp[-c(1, 2)]
     n <- which(dmp == 'weight:')
-    if(length(n) != 1)
+    if (length(n) != 1)
       stop("It does not appear to be a gblinear model")
     num_class <- n - 1
     num_feat <- (length(dmp) - 4) / num_class
@@ -732,9 +730,9 @@ xgb.gblinear.history <- function(model, class_index = NULL) {
   if (!is.null(class_index) && num_class > 1) {
     coef_path <- if (is.list(coef_path)) {
       lapply(coef_path,
-             function(x) x[, seq(1 + class_index, by=num_class, length.out=num_feat)])
+             function(x) x[, seq(1 + class_index, by = num_class, length.out = num_feat)])
     } else {
-      coef_path <- coef_path[, seq(1 + class_index, by=num_class, length.out=num_feat)]
+      coef_path <- coef_path[, seq(1 + class_index, by = num_class, length.out = num_feat)]
     }
   }
   coef_path

R-package/R/utils.R

@@ -69,23 +69,23 @@ check.booster.params <- function(params, ...) {
 
   if (!is.null(params[['monotone_constraints']]) &&
       typeof(params[['monotone_constraints']]) != "character") {
-        vec2str = paste(params[['monotone_constraints']], collapse = ',')
-        vec2str = paste0('(', vec2str, ')')
-        params[['monotone_constraints']] = vec2str
+        vec2str <- paste(params[['monotone_constraints']], collapse = ',')
+        vec2str <- paste0('(', vec2str, ')')
+        params[['monotone_constraints']] <- vec2str
   }
 
   # interaction constraints parser (convert from list of column indices to string)
   if (!is.null(params[['interaction_constraints']]) &&
       typeof(params[['interaction_constraints']]) != "character"){
     # check input class
-    if (!identical(class(params[['interaction_constraints']]),'list')) stop('interaction_constraints should be class list')
-    if (!all(unique(sapply(params[['interaction_constraints']], class)) %in% c('numeric','integer'))) {
+    if (!identical(class(params[['interaction_constraints']]), 'list')) stop('interaction_constraints should be class list')
+    if (!all(unique(sapply(params[['interaction_constraints']], class)) %in% c('numeric', 'integer'))) {
       stop('interaction_constraints should be a list of numeric/integer vectors')
     }
 
     # recast parameter as string
-    interaction_constraints <- sapply(params[['interaction_constraints']], function(x) paste0('[', paste(x, collapse=','), ']'))
-    params[['interaction_constraints']] <- paste0('[', paste(interaction_constraints, collapse=','), ']')
+    interaction_constraints <- sapply(params[['interaction_constraints']], function(x) paste0('[', paste(x, collapse = ','), ']'))
+    params[['interaction_constraints']] <- paste0('[', paste(interaction_constraints, collapse = ','), ']')
   }
   return(params)
 }
@@ -167,8 +167,8 @@ xgb.iter.eval <- function(booster_handle, watchlist, iter, feval = NULL) {
   if (is.null(feval)) {
     msg <- .Call(XGBoosterEvalOneIter_R, booster_handle, as.integer(iter), watchlist, as.list(evnames))
     msg <- stri_split_regex(msg, '(\\s+|:|\\s+)')[[1]][-1]
-    res <- as.numeric(msg[c(FALSE,TRUE)]) # even indices are the values
-    names(res) <- msg[c(TRUE,FALSE)]      # odds are the names
+    res <- as.numeric(msg[c(FALSE, TRUE)]) # even indices are the values
+    names(res) <- msg[c(TRUE, FALSE)]      # odds are the names
   } else {
     res <- sapply(seq_along(watchlist), function(j) {
       w <- watchlist[[j]]
@@ -315,8 +315,8 @@ depr_par_lut <- matrix(c(
   'with.stats', 'with_stats',
   'numberOfClusters', 'n_clusters',
   'features.keep', 'features_keep',
-  'plot.height','plot_height',
-  'plot.width','plot_width',
+  'plot.height', 'plot_height',
+  'plot.width', 'plot_width',
   'n_first_tree', 'trees',
   'dummy', 'DUMMY'
 ), ncol = 2, byrow = TRUE)
@@ -329,20 +329,20 @@ colnames(depr_par_lut) <- c('old', 'new')
 check.deprecation <- function(..., env = parent.frame()) {
   pars <- list(...)
   # exact and partial matches
-  all_match <- pmatch(names(pars), depr_par_lut[,1])
+  all_match <- pmatch(names(pars), depr_par_lut[, 1])
   # indices of matched pars' names
   idx_pars <- which(!is.na(all_match))
   if (length(idx_pars) == 0) return()
   # indices of matched LUT rows
   idx_lut <- all_match[idx_pars]
   # which of idx_lut were the exact matches?
-  ex_match <- depr_par_lut[idx_lut,1] %in% names(pars)
+  ex_match <- depr_par_lut[idx_lut, 1] %in% names(pars)
   for (i in seq_along(idx_pars)) {
     pars_par <- names(pars)[idx_pars[i]]
     old_par <- depr_par_lut[idx_lut[i], 1]
     new_par <- depr_par_lut[idx_lut[i], 2]
     if (!ex_match[i]) {
-      warning("'", pars_par, "' was partially matched to '", old_par,"'")
+      warning("'", pars_par, "' was partially matched to '", old_par, "'")
     }
     .Deprecated(new_par, old = old_par, package = 'xgboost')
     if (new_par != 'NULL') {

R-package/R/xgb.Booster.R

@@ -1,6 +1,7 @@
 # Construct an internal xgboost Booster and return a handle to it.
 # internal utility function
-xgb.Booster.handle <- function(params = list(), cachelist = list(), modelfile = NULL) {
+xgb.Booster.handle <- function(params = list(), cachelist = list(),
+                               modelfile = NULL) {
   if (typeof(cachelist) != "list" ||
       !all(vapply(cachelist, inherits, logical(1), what = 'xgb.DMatrix'))) {
     stop("cachelist must be a list of xgb.DMatrix objects")
@@ -62,8 +63,8 @@ is.null.handle <- function(handle) {
   return(FALSE)
 }
 
-# Return a verified to be valid handle out of either xgb.Booster.handle or xgb.Booster
-# internal utility function
+# Return a verified to be valid handle out of either xgb.Booster.handle or
+# xgb.Booster internal utility function
 xgb.get.handle <- function(object) {
   if (inherits(object, "xgb.Booster")) {
     handle <- object$handle
@@ -369,8 +370,8 @@ predict.xgb.Booster <- function(object, newdata, missing = NA, outputmargin = FA
       matrix(ret, nrow = n_row, byrow = TRUE, dimnames = list(NULL, cnames))
     } else {
       arr <- array(ret, c(n_col1, n_group, n_row),
-                   dimnames = list(cnames, NULL, NULL)) %>% aperm(c(2,3,1)) # [group, row, col]
-      lapply(seq_len(n_group), function(g) arr[g,,])
+                   dimnames = list(cnames, NULL, NULL)) %>% aperm(c(2, 3, 1)) # [group, row, col]
+      lapply(seq_len(n_group), function(g) arr[g, , ])
     }
   } else if (predinteraction) {
     n_col1 <- ncol(newdata) + 1
@@ -379,11 +380,11 @@ predict.xgb.Booster <- function(object, newdata, missing = NA, outputmargin = FA
     ret <- if (n_ret == n_row) {
       matrix(ret, ncol = 1, dimnames = list(NULL, cnames))
     } else if (n_group == 1) {
-      array(ret, c(n_col1, n_col1, n_row), dimnames = list(cnames, cnames, NULL)) %>% aperm(c(3,1,2))
+      array(ret, c(n_col1, n_col1, n_row), dimnames = list(cnames, cnames, NULL)) %>% aperm(c(3, 1, 2))
     } else {
       arr <- array(ret, c(n_col1, n_col1, n_group, n_row),
-                   dimnames = list(cnames, cnames, NULL, NULL)) %>% aperm(c(3,4,1,2)) # [group, row, col1, col2]
-      lapply(seq_len(n_group), function(g) arr[g,,,])
+                   dimnames = list(cnames, cnames, NULL, NULL)) %>% aperm(c(3, 4, 1, 2)) # [group, row, col1, col2]
+      lapply(seq_len(n_group), function(g) arr[g, , , ])
     }
   } else if (reshape && npred_per_case > 1) {
     ret <- matrix(ret, nrow = n_row, byrow = TRUE)
@@ -656,7 +657,7 @@ print.xgb.Booster <- function(x, verbose = FALSE, ...) {
 
   if (!is.null(x$params)) {
     cat('params (as set within xgb.train):\n')
-    cat( '  ',
+    cat('  ',
          paste(names(x$params),
                paste0('"', unlist(x$params), '"'),
                sep = ' = ', collapse = ', '), '\n', sep = '')
@@ -669,9 +670,9 @@ print.xgb.Booster <- function(x, verbose = FALSE, ...) {
   if (length(attrs) > 0) {
     cat('xgb.attributes:\n')
     if (verbose) {
-      cat( paste(paste0('  ',names(attrs)),
-                 paste0('"', unlist(attrs), '"'),
-                 sep = ' = ', collapse = '\n'), '\n', sep = '')
+        cat(paste(paste0('  ', names(attrs)),
+                  paste0('"', unlist(attrs), '"'),
+                  sep = ' = ', collapse = '\n'), '\n', sep = '')
     } else {
       cat('  ', paste(names(attrs), collapse = ', '), '\n', sep = '')
     }
@@ -693,7 +694,7 @@ print.xgb.Booster <- function(x, verbose = FALSE, ...) {
   #cat('ntree: ', xgb.ntree(x), '\n', sep='')
 
   for (n in setdiff(names(x), c('handle', 'raw', 'call', 'params', 'callbacks',
-                                'evaluation_log','niter','feature_names'))) {
+                                'evaluation_log', 'niter', 'feature_names'))) {
     if (is.atomic(x[[n]])) {
       cat(n, ':', x[[n]], '\n', sep = ' ')
     } else {

R-package/R/xgb.DMatrix.R

@@ -322,7 +322,7 @@ slice.xgb.DMatrix <- function(object, idxset, ...) {
     for (i in seq_along(ind)) {
       obj_attr <- attr(object, nms[i])
       if (NCOL(obj_attr) > 1) {
-        attr(ret, nms[i]) <- obj_attr[idxset,]
+        attr(ret, nms[i]) <- obj_attr[idxset, ]
       } else {
         attr(ret, nms[i]) <- obj_attr[idxset]
       }
@@ -360,9 +360,9 @@ slice.xgb.DMatrix <- function(object, idxset, ...) {
 print.xgb.DMatrix <- function(x, verbose = FALSE, ...) {
   cat('xgb.DMatrix  dim:', nrow(x), 'x', ncol(x), ' info: ')
   infos <- c()
-  if(length(getinfo(x, 'label')) > 0) infos <- 'label'
-  if(length(getinfo(x, 'weight')) > 0) infos <- c(infos, 'weight')
-  if(length(getinfo(x, 'base_margin')) > 0) infos <- c(infos, 'base_margin')
+  if (length(getinfo(x, 'label')) > 0) infos <- 'label'
+  if (length(getinfo(x, 'weight')) > 0) infos <- c(infos, 'weight')
+  if (length(getinfo(x, 'base_margin')) > 0) infos <- c(infos, 'base_margin')
   if (length(infos) == 0) infos <- 'NA'
   cat(infos)
   cnames <- colnames(x)

R-package/R/xgb.DMatrix.save.R

@@ -1,10 +1,10 @@
 #' Save xgb.DMatrix object to binary file
-#' 
+#'
 #' Save xgb.DMatrix object to binary file
-#' 
+#'
 #' @param dmatrix the \code{xgb.DMatrix} object
 #' @param fname the name of the file to write.
-#' 
+#'
 #' @examples
 #' data(agaricus.train, package='xgboost')
 #' train <- agaricus.train
@@ -18,7 +18,7 @@ xgb.DMatrix.save <- function(dmatrix, fname) {
     stop("fname must be character")
   if (!inherits(dmatrix, "xgb.DMatrix"))
     stop("dmatrix must be xgb.DMatrix")
-  
+
   .Call(XGDMatrixSaveBinary_R, dmatrix, fname[1], 0L)
   return(TRUE)
 }