Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In python module tests paths to the data should be determined relative to __file__ #2973

Closed
KOLANICH opened this issue Dec 24, 2017 · 4 comments

Comments

@KOLANICH
Copy link
Contributor

Now they are just the paths relative to the current directory which makes a one who wanna run the tests to go to the main repo directory first and run the tests from it. It's better to

import os
currentDir=os.path.dirname(__file__)
mainDir=os.path.join(currentDir, "..", "..")

and then compute data paths relative to the main dir

@tqchen tqchen closed this as completed Jul 4, 2018
@KOLANICH
Copy link
Contributor Author

KOLANICH commented Jul 4, 2018

???

@tqchen
Copy link
Member

tqchen commented Jul 4, 2018

The testcase structure is quite common in python and I think we will keep it as it is. We are sorry for the massive close the issues. The main goal is to minimize the amount of issues so that actually the developer can take action on them(currently the issues that fall below the piles are ignored due the amount of opened issues). Please feel free to open new issues when you think is useful.
The discussions are now welcomed at https://discuss.xgboost.ai/

@KOLANICH
Copy link
Contributor Author

KOLANICH commented Jul 4, 2018

@tqchen, I'm also a bit sorry that I have to put code snippets into issues instead of pull requests. BTW, why not to apply machine learning to classify and migrate only Q&A-type issues (with mandatory human wetting!) instead of bulk closing issues even with code and proposals on improvement? I understand the minimizing of count of issues, but instead of closing you can assign them labels. Bulk closing issues is a sign of disrespect to the people who have spent own time to write an issue to improve the project a bit.

@hcho3
Copy link
Collaborator

hcho3 commented Jul 5, 2018

Bulk closing issues is a sign of disrespect to the people who have spent own time to write an issue to improve the project a bit.

Letting a long list of issues rot without any response is also a sign of disrespect. Yes, bulk closing was not quite ideal, but we maintainers feel that having a short, organized list of issues that are actionable would help everyone coordinate efforts.

bulk closing issues even with code and proposals on improvement

We will re-open issues containing bug reports. As for feature requests, we plan to maintain a single list of feature requests (#3439) so that potential contributors could easily find them.

@dmlc dmlc locked as resolved and limited conversation to collaborators Oct 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants