-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider migrating tests from AppVeyor/Travis CI to Azure Pipelines #4498
Comments
+10000 on getting rid of AppVeyor |
I played with Azure Pipelines a bit, and so far it's been pleasure to work with.
See example: azure-pipelines.yml, build result |
Can't wait. |
I am also interested in seeing Azure Pipelines instead of AppVeyor |
We've set up GitHub Actions (#5917) and moved some tests from AppVeyor to GitHub Actions (#5922). There is currently a nondeterministic test that's blocking a further migration away from AppVeyor. We are keeping Travis CI because we need access to MacOS High Sierra to build XGBoost Python wheel. (Expectation is that it will be compatible with last three major releases, High Sierra, Mojave, and Catalina.) GitHub Actions only provides MacOS Catalina. Closing this in favor of #5891. |
@hcho3 I don't think we are running 3 versions of osx on travis right? |
Another thing is, our test on Travis now takes 1.5+ hour to run for each PR. And multiple PRs cannot be run in parallel. |
Travis CI runs multiple Linux jobs just fine. It's just that their MacOS agent pool is really small, so our jobs get stuck in the global queue for a long time. |
No. We assume backward compatibility: if we can build and run XGBoost on MacOS High Sierra, then the generated binary should also be compatible with MacOS Mojave/Catalina. |
Got it. Thanks for the explanation. |
Reopening, since Travis CI seems to be quite slow nowadays. The tests remain in queue for 2-3 hours. (Once they start, they are usually fairly quick.) A proposal: Migrate all MacOS tests to GitHub Actions. GitHub Actions will use MacOS Catalina (latest). Travis CI should only run on the master branch, to generate and upload nightly builds (Python wheels) with MacOS High Sierra. @trivialfis WDYT? |
@hcho3 I'm not sure about the ecosystem on osx. I will leave it to others to decide. ;-) @CodingCat seems also fond of osx. |
I think the backward compatibility of osx is generally guaranteed....
…On Wed, Jul 22, 2020 at 6:43 PM Jiaming Yuan ***@***.***> wrote:
@hcho3 <https://github.com/hcho3> I'm not sure about the ecosystem on
osx. I will leave it to others to decide. ;-) @CodingCat
<https://github.com/CodingCat> seems also fond of osx.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4498 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFFQ6HUV5ESUKI2WKT5TA3R46ITJANCNFSM4HPSVYFA>
.
|
Travis CI seems fine now. |
Consider migrating all tests from AppVeyor/Travis CI to Azure Pipelines.
Why migrate tests?
TODO. Test Azure Pipelines for performance and stability
cc @sriramch
The text was updated successfully, but these errors were encountered: