Saving pkl model changes default encoding

[sh1ng]

xgboost 1.0.0rc2

import xgboost as xgb
import numpy as np
import pickle
import locale


def makeXy():
    np.random.seed(1)
    X = np.random.randn(10, 10)
    y = [0, 1] * int(10 / 2)
    return X, y


X, y = makeXy()

dm = xgb.DMatrix(X, label=y)

param = {
    "objective": "binary:logistic",
    'eval_metric': 'auc',
}

model = xgb.train(param, dm, 1)

print(locale.getpreferredencoding(False))

with open("model.pkl", 'wb') as f:
    pickle.dump(obj=model, file=f)

print(locale.getpreferredencoding(False))

UTF-8
ANSI_X3.4-1968

I'm not quite sure, but could it be related to dmlc-core and changing locale?

[sh1ng]

Thanks

[sh1ng]

@trivialfis are you also going to merge it into release_1 branch?

[trivialfis]

It's merged there.