Fix changing locale. #5314
Merged
Fix changing locale. #5314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As number parsing is implemented in house, we don't need locale.
|
Update: Just don't set the locale, as number parsing is implemented in XGBoost. |
hcho3
approved these changes
Feb 16, 2020
trivialfis
added a commit
that referenced
this pull request
Feb 17, 2020
* Fix changing locale. * Don't use locale guard. As number parsing is implemented in house, we don't need locale. * Update doc.
12 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5313
Don't do anything special if the original locale is
classic. I'm not sure if it's a quality fix, as the default global locale in Python isutf-8whileCin c++. However changing locale in c++ also changes locale in Python ... So they have different getters but same setter..