Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the span class trivially copyable. #10878

Merged
merged 4 commits into from
Oct 9, 2024
Merged

Make the span class trivially copyable. #10878

merged 4 commits into from
Oct 9, 2024

Conversation

trivialfis
Copy link
Member

@trivialfis trivialfis commented Oct 8, 2024 •
edited
Loading

This way, we can use the uvector in more places and catch some more unused variables.

@trivialfis
Make the span class trivially copyable.
0a91649 
This way we can use the uvector in more places.
@trivialfis
unused variables.
2429fb8
@trivialfis trivialfis marked this pull request as draft October 8, 2024 09:07
@trivialfis trivialfis marked this pull request as ready for review October 9, 2024 08:34
@trivialfis trivialfis merged commit f7cb8e0 into dmlc:master Oct 9, 2024
30 checks passed
@trivialfis trivialfis deleted the trivial-span branch October 9, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rongou rongou rongou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trivialfis @rongou