Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated feval. #11051

Merged
merged 9 commits into from
Dec 6, 2024
Merged

Remove deprecated feval. #11051

merged 9 commits into from
Dec 6, 2024

Conversation

trivialfis
Copy link
Member

@trivialfis trivialfis commented Dec 4, 2024 •
edited
Loading

todo:

  • dask
  • tests for the reverse link.

@trivialfis trivialfis changed the title [WIP] Remove deprecated feval. Remove deprecated feval. Dec 4, 2024
@trivialfis trivialfis marked this pull request as ready for review December 4, 2024 12:26
@trivialfis trivialfis requested a review from hcho3 December 4, 2024 14:31
hcho3
hcho3 requested changes Dec 6, 2024
View reviewed changes
python-package/xgboost/training.py Outdated Show resolved Hide resolved
@trivialfis @hcho3
Update python-package/xgboost/training.py
96e1abe 
Co-authored-by: Philip Hyunsu Cho <chohyu01@cs.washington.edu>
@trivialfis trivialfis requested a review from hcho3 December 6, 2024 07:42
@trivialfis trivialfis merged commit c7c158d into dmlc:master Dec 6, 2024
30 checks passed
@trivialfis trivialfis deleted the py-remove-feval branch December 6, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hcho3 hcho3 hcho3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trivialfis @hcho3