Skip to content

Conversation

@trivialfis
Copy link
Member

@trivialfis trivialfis commented Apr 17, 2025

Provide more details on what to use.

@trivialfis trivialfis requested a review from Copilot April 17, 2025 11:57
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request updates documentation related to external memory usage in XGBoost. The changes clarify description details in the core documentation and adjust recommendations in the demo guide.

  • Updated phrasing in the internal documentation on sub-stream memory usage in core.py
  • Modified recommendations in the external memory demo, particularly for the approx tree method

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

File Description
python-package/xgboost/core.py Docstring update for external memory sub-streams
demo/guide-python/external_memory.py Updated recommendation text in function docstrings
Files not reviewed (1)
  • doc/tutorials/external_memory.rst: Language not supported

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@trivialfis trivialfis requested a review from hcho3 April 17, 2025 12:00
@trivialfis
Copy link
Member Author

cc @rongou .

@trivialfis trivialfis merged commit 6886205 into dmlc:master Apr 22, 2025
78 of 80 checks passed
@trivialfis trivialfis deleted the ext-mem-doc branch April 22, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants