Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add qid like ranklib format #2749

Merged
merged 22 commits into from
Jun 30, 2018
Merged

Add qid like ranklib format #2749

merged 22 commits into from
Jun 30, 2018
+182 −15

Commits on Jun 29, 2018

  1. add qid for dmlc#2748

    @hcho3
    liuliang09 authored and hcho3 committed Jun 29, 2018
    Configuration menu
    Copy the full SHA
    9d29c5d View commit details
    Browse the repository at this point in the history

  2. change names

    @hcho3
    liuliang09 authored and hcho3 committed Jun 29, 2018
    Configuration menu
    Copy the full SHA
    fac882e View commit details
    Browse the repository at this point in the history

  3. change spaces

    @hcho3
    liuliang09 authored and hcho3 committed Jun 29, 2018
    Configuration menu
    Copy the full SHA
    e71b874 View commit details
    Browse the repository at this point in the history

  4. change qid to bst_uint type

    @hcho3
    liuliang09 authored and hcho3 committed Jun 29, 2018
    Configuration menu
    Copy the full SHA
    e8d3f4e View commit details
    Browse the repository at this point in the history

  5. change qid type to size_t

    @hcho3
    liuliang09 authored and hcho3 committed Jun 29, 2018
    Configuration menu
    Copy the full SHA
    29dde93 View commit details
    Browse the repository at this point in the history

  6. change qid first to SIZE_MAX

    @hcho3
    liuliang09 authored and hcho3 committed Jun 29, 2018
    Configuration menu
    Copy the full SHA
    ef2b066 View commit details
    Browse the repository at this point in the history

  7. change qid type from size_t to uint64_t

    @hcho3
    liuliang09 authored and hcho3 committed Jun 29, 2018
    Configuration menu
    Copy the full SHA
    2c042dd View commit details
    Browse the repository at this point in the history

  8. update dmlc-core

    @hcho3
    liuliang09 authored and hcho3 committed Jun 29, 2018
    Configuration menu
    Copy the full SHA
    5e3cab1 View commit details
    Browse the repository at this point in the history

  9. fix qids name error

    @hcho3
    liuliang09 authored and hcho3 committed Jun 29, 2018
    Configuration menu
    Copy the full SHA
    0172efc View commit details
    Browse the repository at this point in the history

  10. fix group_ptr_ error

    @hcho3
    liuliang09 authored and hcho3 committed Jun 29, 2018
    Configuration menu
    Copy the full SHA
    812f725 View commit details
    Browse the repository at this point in the history

  11. Style fix

    @hcho3
    hcho3 committed Jun 29, 2018
    Configuration menu
    Copy the full SHA
    4326b3a View commit details
    Browse the repository at this point in the history

  12. Add qid handling logic to SparsePage

    @hcho3
    hcho3 committed Jun 29, 2018
    Configuration menu
    Copy the full SHA
    3654f49 View commit details
    Browse the repository at this point in the history

  13. New MetaInfo format + backward compatibility fix 

    Old MetaInfo format (1.0) doesn't contain qid field. We still want to be able
to read from MetaInfo files saved in old format. Also, define a new format
(2.0) that contains the qid field. This way, we can distinguish files that
contain qid and those that do not.
    @hcho3
    hcho3 committed Jun 29, 2018
    Configuration menu
    Copy the full SHA
    d4ac276 View commit details
    Browse the repository at this point in the history

  14. Update MetaInfo test

    @hcho3
    hcho3 committed Jun 29, 2018
    Configuration menu
    Copy the full SHA
    b2e8582 View commit details
    Browse the repository at this point in the history

  15. Simply group assignment logic

    @hcho3
    hcho3 committed Jun 29, 2018
    Configuration menu
    Copy the full SHA
    265772b View commit details
    Browse the repository at this point in the history

  16. Explicitly set qid=nullptr in NativeDataIter 

    NativeDataIter's callback does not support qid field. Users of NativeDataIter
will need to call setGroup() function separately to set group information.
    @hcho3
    hcho3 committed Jun 29, 2018
    Configuration menu
    Copy the full SHA
    7dabd7f View commit details
    Browse the repository at this point in the history

  17. Save qids_ in SaveBinary()

    @hcho3
    hcho3 committed Jun 29, 2018
    Configuration menu
    Copy the full SHA
    edcd41c View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2018

  1. Upgrade dmlc-core submodule

    @hcho3
    hcho3 committed Jun 30, 2018
    Configuration menu
    Copy the full SHA
    c7dbabc View commit details
    Browse the repository at this point in the history

  2. Add a test for reading qid

    @hcho3
    hcho3 committed Jun 30, 2018
    Configuration menu
    Copy the full SHA
    07971d3 View commit details
    Browse the repository at this point in the history

  3. Add contributor

    @hcho3
    hcho3 committed Jun 30, 2018
    Configuration menu
    Copy the full SHA
    161a3a7 View commit details
    Browse the repository at this point in the history

  4. Check the size of qids_

    @hcho3
    hcho3 committed Jun 30, 2018
    Configuration menu
    Copy the full SHA
    16eebc0 View commit details
    Browse the repository at this point in the history

  5. Document qid format

    @hcho3
    hcho3 committed Jun 30, 2018
    Configuration menu
    Copy the full SHA
    0224125 View commit details
    Browse the repository at this point in the history