Revert #3677 and #3674 #3678
Merged
Revert #3677 and #3674 #3678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxxun
pushed a commit
to mxxun/xgboost
that referenced
this pull request
Sep 7, 2018
CodingCat
pushed a commit
to CodingCat/xgboost
that referenced
this pull request
Sep 18, 2018
alois-bissuel
pushed a commit
to criteo-forks/xgboost
that referenced
this pull request
Dec 4, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3674 adds a few tests in an attempt to pass
check_estimator()test of scikit-learn, but it has broken the doc build. Given that it is actually not possible to passcheck_estimator()entirely (see #3674 for reason why), I think the tests cause a lot of headaches without much tangible benefits. Instead of spending more time to fix it, I think it is more fruitful to revert #3674.From now on, I will be more careful when submitting pull requests.