Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert hist init optimization. #4502

Merged
merged 1 commit into from
May 26, 2019
Merged

Conversation

trivialfis
Copy link
Member

@trivialfis trivialfis requested review from hcho3 May 25, 2019 22:57
@hcho3
Copy link
Collaborator

hcho3 commented May 25, 2019

I will review this shortly.

In general, I think we should pick a few datasets with different characteristics and run benchmarks:

  • Dense dataset with small number of columns
  • Sparse dataset with high number of columns
  • Sparse dataset whose columns are generated by a high-cardinality categorical variables

Also have Jenkins run benchmarks every 2 weeks or so to check performance regression

@trivialfis trivialfis merged commit 55e645c into dmlc:master May 26, 2019
@trivialfis
Copy link
Member Author

That would be a very good idea.

@trivialfis trivialfis deleted the revert-hist branch May 26, 2019 10:23
@thvasilo
Copy link
Contributor

thvasilo commented Jun 3, 2019

@hcho3 The datasets we used in our paper would be good candidates for that.

Bosch: Dense with ~970 features: https://www.kaggle.com/c/bosch-production-line-performance/data
URL: sparse with 3.2M features, generated from text as well as numerical features http://www.sysnet.ucsd.edu/projects/url/
Avazu: Sparse with 1M features https://www.csie.ntu.edu.tw/~cjlin/libsvmtools/datasets/binary.html and https://www.kaggle.com/c/avazu-ctr-prediction/data
RCV1: Sparse with ~47k features, also available at https://www.csie.ntu.edu.tw/~cjlin/libsvmtools/datasets/binary.html

I'm not aware of high-dimensional sparse datasets that were not generated by high-cardinality categorical variables.

One thing to note about URL vs. Avazu is perhaps that avazu strangely uses the value 0.258 (instead of 1) to indicate the presence of a variable, I'm not sure if that affects the parsing (i.e. treating it as a dense variable where it isn't)

@lock lock bot locked as resolved and limited conversation to collaborators Sep 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants