- fix crash with approx tree method on cpu #4510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith external memory
trivialfis
reviewed
May 29, 2019
| @@ -52,4 +53,15 @@ TEST(SparsePage, PushCSC) { | |||
| ASSERT_EQ(inst[i].index, indices_sol[i % 3]); | |||
| } | |||
| } | |||
|
|
|||
| TEST(SparsePage, PushCSCAfterTranspose) { | |||
There was a problem hiding this comment.
Can we have specific expected results other than not crashing in this test?
There was a problem hiding this comment.
i have modified the test. please check now...
|
@trivialfis thanks for your review. can you merge once the build passes? i need this for my tests |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix crash with approx tree method on cpu when training is enabled with external memory
@trivialfis - please review