remove the qids_ field in MetaInfo #4744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rongou I'm afraid we have to maintain its stability. Just give a warning for loading old binary. |
Codecov Report
@@ Coverage Diff @@
## master #4744 +/- ##
=========================================
Coverage ? 79.59%
=========================================
Files ? 11
Lines ? 1965
Branches ? 0
=========================================
Hits ? 1564
Misses ? 401
Partials ? 0Continue to review full report at Codecov.
|
|
@trivialfis added the version. Please take another look. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure how much we care about saved
MetaInfobinaries. If you want I can add the versioning back.Part of the DMatrix refactoring #4354
@trivialfis @RAMitchell