Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't set_params at the end of set_state. #4947

Merged
merged 2 commits into from
Oct 15, 2019
Merged

Don't set_params at the end of set_state. #4947

merged 2 commits into from
Oct 15, 2019

Conversation

trivialfis
Copy link
Member

  • Also fix another issue found in dask prediction.

JohnZed
JohnZed approved these changes Oct 15, 2019
View reviewed changes
Copy link
Contributor

@JohnZed JohnZed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good and fix the pickling issue. Worth considering that test improvement I mention, but I'd consider it optional

tests/python/test_pickling.py Outdated Show resolved Hide resolved
@trivialfis
Don't set_params at the end of set_state.
18a6998 
* Also fix another issue found in dask prediction.
@trivialfis
Copy link
Member Author

trivialfis commented Oct 15, 2019 •
edited
Loading

Also partially revert the previous fix. My brain is fried ... Let me get a thorough look.

@RAMitchell
Copy link
Member

For others following, this appears to be a fundamental error in python serialisation where the model can be pickled and unpickled multiple times, resulting in a different model.

@trivialfis
Add note about prediction.
32661f3 
Don't support other prediction modes at the moment.
@trivialfis trivialfis merged commit 7e72a12 into dmlc:master Oct 15, 2019
JohnZed added a commit to rapidsai/xgboost that referenced this pull request Oct 15, 2019
@JohnZed
Merge pull request #16 from dmlc/master
dc8d8d8 
Don't `set_params` at the end of `set_state`. (dmlc#4947)
@trivialfis trivialfis deleted the fix-pickling branch October 15, 2019 15:15
@trivialfis trivialfis mentioned this pull request Oct 15, 2019
Closed
24 tasks
@lock lock bot locked as resolved and limited conversation to collaborators Jan 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JohnZed JohnZed JohnZed approved these changes

@RAMitchell RAMitchell RAMitchell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trivialfis @RAMitchell @JohnZed