Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement JSON IO for updaters #5094

Merged
merged 3 commits into from
Dec 6, 2019
Merged

Implement JSON IO for updaters #5094

merged 3 commits into from
Dec 6, 2019

Conversation

trivialfis
Copy link
Member

  • Remove parameters in split evaluator.

Another small fraction of #4732 .

@trivialfis
Implement JSON IO for updaters.
7b503cc 
* Remove parameters in split evaluator.
@hcho3 hcho3 changed the title Implement JSON IO for updaters. Remove parameters in split evaluator Dec 6, 2019
@hcho3 hcho3 changed the title Remove parameters in split evaluator Implement JSON IO for updaters Dec 6, 2019
@trivialfis
Copy link
Member Author

trivialfis commented Dec 6, 2019 •
edited
Loading

@hcho3

Having one source of parameters will make our life easier.

After JSON PR, the only duplicated parameter is max_delta_step in TrainParam and PoissonRegressionParam. We will be ready for some sort of parameter validation. You just have to save all parameters in JSON, then compare its keys to user provided parameters.

@trivialfis trivialfis merged commit 7ef5b78 into dmlc:master Dec 6, 2019
@trivialfis trivialfis deleted the json-updaters branch December 6, 2019 16:24
@lock lock bot locked as resolved and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hcho3 hcho3 hcho3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trivialfis @hcho3