Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable OpenMP with Apple Clang (Mac default compiler) #5146

Merged
merged 14 commits into from
Dec 26, 2019
Merged

Enable OpenMP with Apple Clang (Mac default compiler) #5146

merged 14 commits into from
Dec 26, 2019

Commits on Dec 22, 2019

  1. Add OpenMP as CMake target

    @hcho3
    hcho3 committed Dec 22, 2019
    Configuration menu
    Copy the full SHA
    340c54b View commit details
    Browse the repository at this point in the history

  2. Use CMake 3.9 in CPU docker image

    @hcho3
    hcho3 committed Dec 22, 2019
    Configuration menu
    Copy the full SHA
    685875f View commit details
    Browse the repository at this point in the history

  3. Require CMake 3.12, to allow linking OpenMP target to objxgboost

    @hcho3
    hcho3 committed Dec 22, 2019
    Configuration menu
    Copy the full SHA
    42fe876 View commit details
    Browse the repository at this point in the history

  4. Adjust CMake version in CPU docker image

    @hcho3
    hcho3 committed Dec 22, 2019
    Configuration menu
    Copy the full SHA
    cb8ca98 View commit details
    Browse the repository at this point in the history

  5. Specify OpenMP compiler flag for CUDA host compiler

    @hcho3
    hcho3 committed Dec 22, 2019
    Configuration menu
    Copy the full SHA
    fec00b7 View commit details
    Browse the repository at this point in the history

Commits on Dec 23, 2019

  1. Address reviewer's comment

    @hcho3
    hcho3 committed Dec 23, 2019
    Configuration menu
    Copy the full SHA
    1f9a5c0 View commit details
    Browse the repository at this point in the history

  2. Require CMake 3.16+ if the OS is Mac OSX

    @hcho3
    hcho3 committed Dec 23, 2019
    Configuration menu
    Copy the full SHA
    95d37cf View commit details
    Browse the repository at this point in the history

  3. Use AppleClang in Mac tests

    @hcho3
    hcho3 committed Dec 23, 2019
    Configuration menu
    Copy the full SHA
    e6209ee View commit details
    Browse the repository at this point in the history

  4. Make CMake build verbose in Travis, to aid debugging

    @hcho3
    hcho3 committed Dec 23, 2019
    Configuration menu
    Copy the full SHA
    2040c04 View commit details
    Browse the repository at this point in the history

  5. Temporarily switch dmlc-core to my fork

    @hcho3
    hcho3 committed Dec 23, 2019
    Configuration menu
    Copy the full SHA
    156e912 View commit details
    Browse the repository at this point in the history

  6. Make conda command available from bash shell

    @hcho3
    hcho3 committed Dec 23, 2019
    Configuration menu
    Copy the full SHA
    99dc415 View commit details
    Browse the repository at this point in the history

  7. Require 3.16+ for Mac only when USE_OPENMP is set

    @hcho3
    hcho3 committed Dec 23, 2019
    Configuration menu
    Copy the full SHA
    bec99c3 View commit details
    Browse the repository at this point in the history

Commits on Dec 26, 2019

  1. Update dmlc-core

    @hcho3
    hcho3 committed Dec 26, 2019
    Configuration menu
    Copy the full SHA
    2b13439 View commit details
    Browse the repository at this point in the history

  2. Use nproc

    @hcho3
    hcho3 committed Dec 26, 2019
    Configuration menu
    Copy the full SHA
    16395a6 View commit details
    Browse the repository at this point in the history