Try avoiding test fixtures. #5270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hcho3 The error on travis seems gone. |
|
@trivialfis Nice! Should this be also included in 1.0.0 release? |
|
Not needed. Just the fixture used in test. |
|
@hcho3 Actually please cherry pick it, as it helps having successful tests on that branch. |
12 tasks
hcho3
pushed a commit
that referenced
this pull request
Feb 4, 2020
* Fix Travis OSX timeout. * Fix classifier.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing for Travis. Please ignore until WIP label is removed.