Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CMake + MSVC build with setuptools. #5280

Merged
merged 1 commit into from
Feb 5, 2020

Conversation

trivialfis
Copy link
Member

Follow up fix for #5271 .

@trivialfis
Copy link
Member Author

There are sdist tests on travis for OSX and Linux. But no such test for Windows yet.

@hcho3
Copy link
Collaborator

hcho3 commented Feb 4, 2020

Usually, Windows users do not have CMake or MSVC installed on their machines. We should document that running build_ext on Windows requires CMake and MSVC.

@trivialfis
Copy link
Member Author

@hcho3 We have documents for building C++ library. Also I added some notes here: https://xgboost.readthedocs.io/en/latest/build.html#python-package-installation at last PR. Do you think it's enough?

@hcho3
Copy link
Collaborator

hcho3 commented Feb 4, 2020

@trivialfis I have not had a chance to look at #5271 thoroughly. The updated doc looks good to me. I think we should add a note about needing MSVC specifically for Windows Python.

@trivialfis
Copy link
Member Author

@hcho3 Got it. I will add some notes. Feel free to provide your feedback on the new setuptools script.

@hcho3
Copy link
Collaborator

hcho3 commented Feb 4, 2020

Actually, never mind. For now we can keep the build doc as it is. I do want to re-organize the build doc later, something like https://rapids.ai/start.html. See #5282

@trivialfis
Copy link
Member Author

trivialfis commented Feb 4, 2020

Actually, never mind. For now we can keep the build doc as it is. I do want to re-organize the build doc later, something like https://rapids.ai/start.html

That's not a link to rapids build doc? BTW, how do I remove the use of silent parameter in the about section of our landing page: https://xgboost.ai/about

Note:

I think there's minor difference around using CMake between 3.13 and later versions with MSVC. I use CMake 3.16 for this PR.

@hcho3
Copy link
Collaborator

hcho3 commented Feb 4, 2020

how do I remove the use of silent parameter in the about section of our landing page

You should submit a patch to https://github.com/xgboost-ai/xgboost-ai.github.io.

That's not a link to rapids build doc?

You can select "Source" in the selector and it display a link to build instruction. MXNet (https://mxnet.apache.org/get_started) does a similar thing. The idea is to make the installation doc page less overwhelming, by letting the user filter the doc by the use case they have in mind.

@hcho3
Copy link
Collaborator

hcho3 commented Feb 4, 2020

I think there's minor difference around using CMake between 3.13 and later versions with MSVC. I use CMake 3.16 for this PR.

Interesting. I was not aware of the difference.

@trivialfis
Copy link
Member Author

Got it. Thanks for the pointers.

@trivialfis
Copy link
Member Author

@hcho3 I read this answer https://stackoverflow.com/questions/28350214/how-to-build-x86-and-or-x64-on-windows-from-command-line-with-cmake

I just took the simplest one (<3.13) and it works even I'm running 3.16. Not sure about the implications.

@trivialfis trivialfis merged commit 84e395d into dmlc:master Feb 5, 2020
@trivialfis trivialfis deleted the pip-windows branch February 5, 2020 02:47
@hcho3 hcho3 mentioned this pull request Feb 21, 2020
12 tasks
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants