Remove update prediction cache from predictors. #5312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivialfis
force-pushed
the
remove-update-cache
branch
from
4b37fea
to
2f5e572
Compare
Codecov Report
@@ Coverage Diff @@
## master #5312 +/- ##
=======================================
Coverage 83.76% 83.76%
=======================================
Files 11 11
Lines 2409 2409
=======================================
Hits 2018 2018
Misses 391 391 Continue to review full report at Codecov.
|
RAMitchell
approved these changes
Feb 16, 2020
trivialfis
added a commit
to trivialfis/xgboost
that referenced
this pull request
Apr 12, 2020
The issue is resolved in dmlc#5312 .
trivialfis
added a commit
that referenced
this pull request
Apr 14, 2020
* Update doc for copying booster. [skip ci] The issue is resolved in #5312 . * Add version for new APIs. [skip ci]
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move this function into gbtree, and uses only updater for doing so. As now the predictor knows exactly how many trees to predict, there's no need for it to update the prediction cache.
GetPredictorinto a CC file.This is part of on going work to enable prediction from
EllpackDMatrix.