Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Predict on Ellpack. #5327

Merged
merged 5 commits into from
Feb 22, 2020
Merged

Predict on Ellpack. #5327

merged 5 commits into from
Feb 22, 2020

Conversation

trivialfis
Copy link
Member

@trivialfis trivialfis commented Feb 20, 2020 •
edited
Loading

  • Unify GPU prediction node.
  • Add PageExists.
  • Dispatch prediction on input data.

Extracted from #5319 . CPU version might not be coming very soon. I'm having trouble in understanding the Column matrix.

Moving the conversation in #5319 (comment) to here.

@trivialfis
Predict on Ellpack.
3f0453a 
* Unify GPU prediction node.
* Add `PageExists`.
* Dispatch prediction on input data.
@trivialfis
Copy link
Member Author

trivialfis commented Feb 20, 2020 •
edited
Loading

I see. Any element assigned to bin 0 must have value < 1.532 based on the way the bins are constructed

The correct way is shifting the bin index by one. When bin index is 0, we use min_fvalue instead.

Maybe you can produce a few test cases verifying these scenarios.

The testing is covered by serialization tests and newly added prediction tests.

@hcho3 hcho3 mentioned this pull request Feb 21, 2020
Closed
12 tasks
RAMitchell
RAMitchell approved these changes Feb 22, 2020
View reviewed changes
Copy link
Member

@RAMitchell RAMitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@trivialfis trivialfis merged commit 655cf17 into dmlc:master Feb 22, 2020
@trivialfis trivialfis deleted the gpu-ellplack-predict branch February 22, 2020 22:27
@lock lock bot locked as resolved and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@RAMitchell RAMitchell RAMitchell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trivialfis @RAMitchell