Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pruner. #5335

Merged
merged 4 commits into from
Feb 25, 2020
Merged

Fix pruner. #5335

merged 4 commits into from
Feb 25, 2020

Conversation

trivialfis
Copy link
Member

@trivialfis trivialfis commented Feb 21, 2020 •
edited
Loading

  • Honor the tree depth.
  • Prevent pruning pruned node.

Closes #5297

Note that leaf_child_cnt is no longer used in XGBoost.

RAMitchell
RAMitchell approved these changes Feb 24, 2020
View reviewed changes
Copy link
Member

@RAMitchell RAMitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trivialfis trivialfis merged commit e0509b3 into dmlc:master Feb 25, 2020
@trivialfis trivialfis deleted the fix-prune branch February 25, 2020 00:33
@stephenpardy stephenpardy mentioned this pull request Feb 28, 2020
Closed
@trivialfis trivialfis mentioned this pull request Apr 21, 2020
Closed
12 tasks
@lock lock bot locked as resolved and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@RAMitchell RAMitchell RAMitchell approved these changes

@hcho3 hcho3 Awaiting requested review from hcho3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't refresh twice or more once pruning happens in the first refresh
2 participants
@trivialfis @RAMitchell