Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dask] Honor nthreads from dask worker. #5414

Merged
merged 2 commits into from
Mar 15, 2020
Merged

[dask] Honor nthreads from dask worker. #5414

merged 2 commits into from
Mar 15, 2020

Conversation

trivialfis
Copy link
Member

@trivialfis trivialfis commented Mar 14, 2020 •
edited
Loading

Check nthreads from dask worker. This parameter can be set by:

    with LocalCluster(n_workers=7, threads_per_worker=1) as cluster:

or similar command line argument of dask-worker.

RAMitchell
RAMitchell reviewed Mar 15, 2020
View reviewed changes
Copy link
Member

@RAMitchell RAMitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any documentation/tests?

@trivialfis
Copy link
Member Author

trivialfis commented Mar 15, 2020 •
edited
Loading

@RAMitchell I'm not sure how to test it.

Update:
Added a test with JSON config.

@trivialfis trivialfis merged commit 761a5db into dmlc:master Mar 15, 2020
@trivialfis trivialfis deleted the dask-nthread branch March 15, 2020 20:51
trivialfis added a commit to trivialfis/xgboost that referenced this pull request Mar 24, 2020
@trivialfis
[dask] Honor nthreads from dask worker. (dmlc#5414)
e55ebe1
@trivialfis trivialfis mentioned this pull request Apr 21, 2020
Closed
12 tasks
@lock lock bot locked as resolved and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@RAMitchell RAMitchell RAMitchell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trivialfis @RAMitchell