Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dask] Use DMLC_TASK_ID. #5415

Merged
merged 1 commit into from
Mar 15, 2020
Merged

[dask] Use DMLC_TASK_ID. #5415

merged 1 commit into from
Mar 15, 2020

Conversation

trivialfis
Copy link
Member

@trivialfis trivialfis commented Mar 14, 2020

Used to make better logging in rabit. Without this parameter, it would be:

task NULL got new rank 0

@codecov-io
Copy link

Codecov Report

Merging #5415 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5415      +/-   ##
==========================================
+ Coverage   84.07%   84.08%   +0.01%     
==========================================
  Files          11       11              
  Lines        2411     2413       +2     
==========================================
+ Hits         2027     2029       +2     
  Misses        384      384              
Impacted Files Coverage Δ
python-package/xgboost/dask.py 90.36% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab7a46a...db913d8. Read the comment docs.

@trivialfis trivialfis merged commit 668e432 into dmlc:master Mar 15, 2020
@trivialfis trivialfis deleted the dask-task-id branch March 15, 2020 08:47
trivialfis added a commit to trivialfis/xgboost that referenced this pull request Mar 24, 2020
@trivialfis trivialfis mentioned this pull request Apr 21, 2020
12 tasks
@lock lock bot locked as resolved and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants