Enable building rabit on Windows #6105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let’s remove the Rabit Makefile, since XGBoost doesn’t use Makefile. |
|
@hcho3 We have R package .. |
|
Ah so Rabit is not part of the amalgamation and it needs a Makefile. Got it. |
7 tasks
|
It seems autotools is picking mingw over msvc. |
trivialfis
force-pushed
the
rabit-windows
branch
from
3e87aa6
to
353bced
Compare
|
Turns out I can remove the makefile. |
trivialfis
force-pushed
the
rabit-windows
branch
from
ff24aaf
to
e6c88c8
Compare
RAMitchell
reviewed
Sep 10, 2020
| #endif // defined(_WIN32) | ||
|
|
||
| #define IS_MINGW() defined(__MINGW32__) |
There was a problem hiding this comment.
Ifdef'ing everything seems quite a messy solution. Any alternatives?
There was a problem hiding this comment.
I don't have any other options.
There was a problem hiding this comment.
I can think of anything better, as you said at least it's constrained to one file.
hcho3
reviewed
Sep 11, 2020
hcho3
reviewed
Sep 11, 2020
hcho3
approved these changes
Sep 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No test is performed. Just trying to get rid of the
rabit_emptytarget.