-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support early stopping with training continuation, correct num boosted rounds. #6506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hcho3
reviewed
Dec 15, 2020
hcho3
approved these changes
Dec 15, 2020
trivialfis
commented
Dec 16, 2020
trivialfis
force-pushed
the
num_boosted_rounds
branch
2 times, most recently
from
December 16, 2020 10:06
70d1b79
to
e901ffd
Compare
hcho3
requested changes
Dec 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revise test_early_stopping_continuation
since it's failing now.
trivialfis
commented
Dec 16, 2020
5 tasks
* Add new C API for obtaining boosted rounds. Co-authored-by: Philip Hyunsu Cho <chohyu01@cs.washington.edu>
trivialfis
force-pushed
the
num_boosted_rounds
branch
from
December 17, 2020 09:59
fc0def1
to
b6d2b35
Compare
@trivialfis Can you extract a PR to fix #6514? Or is this whole PR necessary to fix #6514? |
Just a small part. I will extract that out and port it to 1.3 via PR. |
hcho3
approved these changes
Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #6322
Close #6514
Close #5192 .