Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dask] Accept Future of model for prediction. #6650

Merged
merged 5 commits into from
Feb 2, 2021
Merged

[dask] Accept Future of model for prediction. #6650

merged 5 commits into from
Feb 2, 2021

Conversation

trivialfis
Copy link
Member

@trivialfis trivialfis commented Jan 28, 2021 •
edited
Loading

This PR changes predict and inplace_predict to accept a Future of model, to avoid sending models to workers repeatably.

@trivialfis
Copy link
Member Author

trivialfis commented Jan 28, 2021 •
edited
Loading

I believe to this point we can safely close #5729 .

Also, document is updated to reflect functionality additions in recent changes.

@trivialfis
Copy link
Member Author

Note to myself: Make sure the cache doesn't go into serialization.

@trivialfis trivialfis force-pushed the pre-scatter-booster branch 2 times, most recently from f05ebbf to eff113c Compare January 29, 2021 20:44
@trivialfis trivialfis merged commit 87ab1ad into dmlc:master Feb 2, 2021
@trivialfis trivialfis deleted the pre-scatter-booster branch February 2, 2021 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RAMitchell RAMitchell RAMitchell approved these changes

Assignees
No one assigned
Labels
status: need review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trivialfis @RAMitchell