Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for regression metrics with weights. #6729

Merged
merged 1 commit into from
Feb 25, 2021

Conversation

Roffild
Copy link
Contributor

@Roffild Roffild commented Feb 24, 2021

Tests for regression metrics with weights.

@Roffild Roffild mentioned this pull request Feb 24, 2021
Copy link
Member

@trivialfis trivialfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding tests! Could you please rebase to latest master branch?

@Roffild
Copy link
Contributor Author

Roffild commented Feb 25, 2021

At the time of publication, this was the last commit to master.

Github adds all missed commits to the pull request.

@codecov-io
Copy link

codecov-io commented Feb 25, 2021

Codecov Report

Merging #6729 (00a2121) into master (a4101de) will increase coverage by 0.10%.
The diff coverage is 86.39%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6729      +/-   ##
==========================================
+ Coverage   81.55%   81.65%   +0.10%     
==========================================
  Files          13       13              
  Lines        3719     3800      +81     
==========================================
+ Hits         3033     3103      +70     
- Misses        686      697      +11     
Impacted Files Coverage Δ
python-package/xgboost/data.py 62.63% <77.77%> (+0.07%) ⬆️
python-package/xgboost/sklearn.py 90.14% <80.55%> (-0.56%) ⬇️
python-package/xgboost/core.py 82.39% <85.10%> (+0.54%) ⬆️
python-package/xgboost/dask.py 82.57% <90.66%> (-0.10%) ⬇️
python-package/xgboost/training.py 95.60% <100.00%> (+0.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c375173...00a2121. Read the comment docs.

@trivialfis
Copy link
Member

Thanks for the PR!

@trivialfis trivialfis merged commit 1fa6793 into dmlc:master Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants