-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize the installation documents. #6877
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Split up installation and building from source. * Use consistent section titles. The installation doc is split into 2 sections, one for stable release another for nightly build. Each section contains subsections for Python, R and JVM. Also building from source code is now an independent page detailing the instructions for each package.
hcho3
requested changes
Apr 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done! I like how the new installation doc is organized. I have some minor comments.
Co-authored-by: Philip Hyunsu Cho <chohyu01@cs.washington.edu>
Thanks for the suggestions, all applied. |
hcho3
reviewed
Apr 21, 2021
hcho3
reviewed
Apr 21, 2021
hcho3
approved these changes
Apr 21, 2021
Co-authored-by: Philip Hyunsu Cho <chohyu01@cs.washington.edu>
Co-authored-by: Philip Hyunsu Cho <chohyu01@cs.washington.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The installation doc is split into 2 sections, one for stable release another for the nightly build. Each section contains subsections for Python, R, and JVM.
Also building from source code is now an independent page detailing the instructions for each package.
It's nowhere close to what #5282 is describing, but I think at least it cleanups the current document a little bit.
Here are the TOCs for installation and build:
Install
Build