Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract histogram builder from CPU Hist. #7152

Merged
merged 20 commits into from
Aug 9, 2021

Conversation

trivialfis
Copy link
Member

@trivialfis trivialfis commented Aug 2, 2021

  • Fixes incorrect tests where distributed methods are not actually tested.
  • Extract histogram builder to be a reusable module.

Perf

Dataset Train time Accuracy
Before HIGGS 191.195842235989 0.7342790909090909
covtype 74.0480548529886 0.9398466476769103
After HIGGS 184.16188054496888 0.7342790909090909
covtype 68.06914013501955 0.9398466476769103

@trivialfis trivialfis mentioned this pull request Aug 2, 2021
67 tasks
@trivialfis trivialfis changed the title [WIP] Extract histogram builder from CPU Hist. Extract histogram builder from CPU Hist. Aug 5, 2021
@trivialfis trivialfis marked this pull request as ready for review August 5, 2021 11:32
@trivialfis
Copy link
Member Author

@ShvetsKS

@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2021

Codecov Report

Merging #7152 (16c3d11) into master (f1a4a1a) will increase coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7152      +/-   ##
==========================================
+ Coverage   82.19%   82.37%   +0.17%     
==========================================
  Files          13       13              
  Lines        3999     4017      +18     
==========================================
+ Hits         3287     3309      +22     
+ Misses        712      708       -4     
Impacted Files Coverage Δ
python-package/xgboost/sklearn.py 89.37% <0.00%> (-0.40%) ⬇️
python-package/xgboost/core.py 83.93% <0.00%> (ø)
python-package/xgboost/dask.py 82.33% <0.00%> (ø)
python-package/xgboost/callback.py 82.20% <0.00%> (ø)
python-package/xgboost/training.py 95.34% <0.00%> (+0.04%) ⬆️
python-package/xgboost/data.py 70.01% <0.00%> (+2.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1a4a1a...16c3d11. Read the comment docs.

@ShvetsKS
Copy link
Contributor

ShvetsKS commented Aug 9, 2021

@trivialfis sorry for long response.
LGTM
I didn't observe any degradations also
Thanks for great refactoring

@trivialfis trivialfis merged commit 149f209 into dmlc:master Aug 9, 2021
@trivialfis trivialfis deleted the histogram-builder branch August 9, 2021 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants