Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small refactor for hist builder. #8698

Merged
merged 1 commit into from
Jan 30, 2023
Merged

Small refactor for hist builder. #8698

merged 1 commit into from
Jan 30, 2023

Conversation

trivialfis
Copy link
Member

  • Use span instead of vector as parameter. No perf change as the builder work on pointer.
  • Use const pointer for reg tree.

Part of #8616 .

@trivialfis
Small refactor for hist builder.
e822d5d 
- Use span instead of vector as parameter. No perf change as the builder work on pointer.
- Use const pointer for reg tree.
@trivialfis trivialfis merged commit 21a28f2 into dmlc:master Jan 30, 2023
@trivialfis trivialfis deleted the refactor-hist-builder branch January 30, 2023 06:06
@ShellLM ShellLM mentioned this pull request Aug 11, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hcho3 hcho3 hcho3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trivialfis @hcho3