Define multi-strategy parameter. #8890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivialfis
commented
Mar 9, 2023
| @@ -779,9 +810,17 @@ class LearnerConfiguration : public Learner { | |||
| if (obj_ == nullptr || tparam_.objective != old.objective) { | |||
| obj_.reset(ObjFunction::Create(tparam_.objective, &ctx_)); | |||
| } | |||
|
|
|||
| bool has_nc {cfg_.find("num_class") != cfg_.cend()}; | |||
There was a problem hiding this comment.
This change is made to fix the removed lines above. The change limits the inserted parameter into this function instead of propagating it through the entire library.
trivialfis
commented
Mar 9, 2023
| @@ -12,10 +12,11 @@ | |||
| #include <vector> | |||
|
|
|||
| #include "xgboost/c_api.h" | |||
| #include "xgboost/data.h" // DMatrix | |||
| #include "xgboost/data.h" // DMatrix | |||
| #include "xgboost/feature_map.h" // for FeatureMap | |||
There was a problem hiding this comment.
The feature map is no longer included in learner.h. This is to fix missing includes.
hcho3
requested changes
Mar 10, 2023
hcho3
reviewed
Mar 10, 2023
include/xgboost/learner.h
Outdated
|
|
||
| void Copy(LearnerModelParam const& that); | ||
| [[nodiscard]] bool IsVectorLeaf() const noexcept { return multi_strategy == Strategy::kMono; } |
There was a problem hiding this comment.
Reminder to myself: Treelite should soon add ability to handle vector leaf outputs from XGBoost models
There was a problem hiding this comment.
It will take some time to mature. The current implementation is less than alpha.
hcho3
approved these changes
Mar 10, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #8616 .
The naming is
compofor composite andmonofor monolithic. It's probably not the best name, please make your suggestions. ;-)Sorry for polluting the change with include-what-you-use comments. I can remove them if it makes review difficult.
I plan to slowly integrate it into the xgboost code base to have a clear view of what we are using and to eliminate unneeded includes to reduce compile time. If reviewers prefer having a dedicated PR for header changes, please let me know in the comments. ;-)