Skip to content

Conversation

@tqchen
Copy link
Member

@tqchen tqchen commented Mar 4, 2016

…e thread-safe by using thread local variables.

…e thread-safe by using thread local variables.
@tqchen
Copy link
Member Author

tqchen commented Mar 4, 2016

@tqchen
Copy link
Member Author

tqchen commented Mar 4, 2016

  • Currently the copy of libxgboost4j library and tracker.py is by create_jni.sh
  • We will want to use pom and maven to handle these automatically in the future

@tqchen
Copy link
Member Author

tqchen commented Mar 4, 2016

@CodingCat it seems to me that the interface Booster is not necessary. As we will only have one version of Booster each, for scala and java.

@tqchen
Copy link
Member Author

tqchen commented Mar 4, 2016

please also help review the serializable commit tqchen@0df2ed8 I feel I did it right.

delete FileUtil class

fix bugs
@CodingCat
Copy link
Member

@tqchen I made some changes to the current implementation, mainly for adding some trackable logging statements. and removed the FileUtil, as that static function is only used by NativeLibLoader

for Booster interface , let's leave it there, I'm not sure if we will have more Impl in the projects relying on the core xgboost4j....

PR: tqchen#2

CodingCat and others added 2 commits March 4, 2016 10:55
revise the RabitTracker Impl & delete FileUtil class
tqchen added a commit that referenced this pull request Mar 4, 2016
[DIST] Enable multiple thread  make rabit and xgboost threadsafe
@tqchen tqchen merged commit 770b345 into dmlc:master Mar 4, 2016
@lock lock bot locked as resolved and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants