Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added trigger action model #1003

Merged
merged 78 commits into from
Feb 1, 2024
Merged

Conversation

hinashi
Copy link
Contributor

@hinashi hinashi commented Nov 9, 2023

Summary

Added new feature to be able to update Entry automatically in association with user-defined condition (named TriggerCondition that describes which Attribute will be updated by specified value(TriggerAction) when specified Attribute(s) are updated with expected value(s)).

@userlocalhost
Copy link
Member

userlocalhost commented Nov 27, 2023

Note

  • Use UpdateSerializer to update Entry and its related processings
  • Mkae processing to prevent updating loop of configured Entries

@userlocalhost userlocalhost marked this pull request as ready for review November 28, 2023 07:31
@userlocalhost userlocalhost changed the title WIP: Added trigger action model Added trigger action model Nov 29, 2023
@userlocalhost
Copy link
Member

Up to this point, it's completed to implement feature of TriggerCondition and TriggerAction that changes configured Attribute values when an Entry is updated through APIv2.

@hinashi hinashi marked this pull request as draft December 11, 2023 06:24
@userlocalhost userlocalhost marked this pull request as ready for review February 1, 2024 08:02
@userlocalhost userlocalhost force-pushed the feature/airone_trigger branch from ca28920 to 95555fd Compare February 1, 2024 08:34
Copy link

github-actions bot commented Feb 1, 2024

⚡ ⚡ ⚡ Now the latest apiv2 client npm package is available at:
https://github.com/dmm-com/airone/pkgs/npm/airone-apiclient-typescript-fetch/versions

@codecov-commenter
Copy link

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (deb02aa) 71.82% compared to head (3cce04c) 71.75%.

Files Patch % Lines
frontend/src/repository/AironeApiClient.ts 50.00% 3 Missing and 3 partials ⚠️
frontend/src/Routes.ts 75.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1003      +/-   ##
==========================================
- Coverage   71.82%   71.75%   -0.08%     
==========================================
  Files         120      120              
  Lines        4274     4287      +13     
  Branches     1134     1140       +6     
==========================================
+ Hits         3070     3076       +6     
- Misses       1116     1120       +4     
- Partials       88       91       +3     
Flag Coverage Δ
ui 71.75% <63.15%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hinashi hinashi merged commit da429e6 into dmm-com:master Feb 1, 2024
5 checks passed
@hinashi hinashi deleted the feature/airone_trigger branch February 1, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants