Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Onboard to create-typescript-app@1 #54

Closed
JoshuaKGoldberg opened this issue Jul 17, 2023 · 1 comment · Fixed by #55
Closed

Onboard to create-typescript-app@1 #54

JoshuaKGoldberg opened this issue Jul 17, 2023 · 1 comment · Fixed by #55
Assignees
@JoshuaKGoldberg
Labels
area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this!

Comments

@JoshuaKGoldberg
Copy link
Collaborator

JoshuaKGoldberg commented Jul 17, 2023 •
edited
Loading

Splitting out the last step from #36: I'd like to onboard most or all of the tooling set up in http://github.com/JoshuaKGoldberg/template-typescript-node-package https://github.com/JoshuaKGoldberg/create-typescript-app.
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Jul 17, 2023
Merged
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Jul 30, 2023
@JoshuaKGoldberg JoshuaKGoldberg added the status: accepting prs Please, send a pull request to resolve this! label Jul 30, 2023
@JoshuaKGoldberg JoshuaKGoldberg changed the title Onboard to template-typescript-node-package Onboard to create-typescript-app@1 Sep 5, 2023
@JoshuaKGoldberg JoshuaKGoldberg added the area: tooling Managing the repository's maintenance label Sep 5, 2023
JoshuaKGoldberg added a commit that referenced this issue Nov 12, 2023
@JoshuaKGoldberg
build: onboarded to create-typescript-app (mostly) (#55)
f1b814e 
Fixes #54.

Adds all the tooling from that template, except:
* Jest is still used for tests instead of Vitest to make that transition
easier
* Babel is used for building to go along with ☝️
(egoist/tsup#665)
* The output directory stays as `dist/`, not the template's default
`lib/`
* https://github.com/JoshuaKGoldberg/sentences-per-line: as it conflicts
with eslint-doc-generator

Adds an explicit _"works with spaces"_ test alongside the existing
_"works with tabs"_ now that the repo is switched to tabs.
@github-actions GitHub Actions
Copy link

🎉 This is included in version v1.5.2 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: onboarded to create-typescript-app (mostly) dmnd/dedent
1 participant
@JoshuaKGoldberg