Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable tab compatbility #28

Merged
merged 2 commits into from
May 22, 2023
Merged

Conversation

adrianjost
Copy link
Contributor

This is a basic implementation to allow tab usage. I handle each tab like a single space character. In most cases this should be fine as it's really rare that tabs and spaces are mixed.

Issue: #10

Copy link

@b0g3r b0g3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adrianjost
Copy link
Contributor Author

adrianjost commented Apr 14, 2019

@dmnd, @Haroenv could you give an estimation, when this pull might get merged?

@adrianjost
Copy link
Contributor Author

If someone is finding this pr and is looking for a fast fix: I published a version with my fix on npm.

Copy link

@aleclarson aleclarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @dmnd?

dedent.js Outdated Show resolved Hide resolved
@kimjson
Copy link

kimjson commented Dec 16, 2020

when is it going to be merged?

@adrianjost
Copy link
Contributor Author

adrianjost commented Dec 16, 2020

@SorryKim I wouldn't expect this to be merged in a timely manner. The project is inactive for over 3 years now. If you really need this feature, I would recommend you using dedent-tabs which is a fork of this project I still maintain and has this feature built in.

Copy link
Collaborator

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 this looks great, thanks @adrianjost!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 4c1969e into dmnd:master May 22, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request May 22, 2023
@fisker
Copy link

fisker commented May 24, 2023

That's fast.

@adrianjost adrianjost deleted the support-tabs branch May 24, 2023 08:13
@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants