make switchBy work with non string values (#183)

dmno-dev · Dec 16, 2024 · 82d2179 · 82d2179
1 parent 2f06afe
commit 82d2179
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 1 deletion.
diff --git a/.changeset/silly-students-talk.md b/.changeset/silly-students-talk.md
@@ -0,0 +1,5 @@
+---
+"@dmno/configraph": patch
+---
+
+make switchBy work with non string values
diff --git a/packages/configraph/src/resolvers/switch.ts b/packages/configraph/src/resolvers/switch.ts
@@ -21,7 +21,7 @@ export function switchBy(switchByKey: string, branches: SwitchByResolverOptions)
     resolveBranches: _.map(branches, (itemDef, itemKey) => ({
       // TODO: do we want to use a special symbol? or pass default as different arg?
       isDefault: itemKey === '_default' || itemKey === '_',
-      condition: (ctx: ResolverContext) => ctx.get(switchByKey) === itemKey,
+      condition: (ctx: ResolverContext) => ctx.get(switchByKey)?.toString() === itemKey,
       id: itemKey,
       label: `${switchByKey} === "${itemKey}"`,
       resolver: processInlineResolverDef(itemDef),

diff --git a/packages/configraph/test/resolution.test.ts b/packages/configraph/test/resolution.test.ts
@@ -143,6 +143,23 @@ describe('graph resolution', () => {
       expect(e.configNodes.switchTest.resolvedValue).toBe('default-val');
     });
 
+    test('works with non-string values', async () => {
+      const g = new Configraph();
+      const e = g.createEntity({
+        configSchema: {
+          someBool: { value: true },
+          switchTest: {
+            value: switchBy('someBool', {
+              true: 'true-val',
+              false: 'false-val',
+            }),
+          },
+        },
+      });
+      await g.resolveConfig();
+      expect(e.configNodes.switchTest.resolvedValue).toBe('true-val');
+    });
+
     test('item has a SchemaError if key/path is not valid', async () => {
       const g = new Configraph();
       const e = g.createEntity({